[PATCH v20 02/10] doc: fpga-mgr: add fpga image info to api
From: moritz.fischer@ettus.com (Moritz Fischer)
Date: 2016-10-17 21:00:28
Also in:
linux-devicetree, lkml
From: moritz.fischer@ettus.com (Moritz Fischer)
Date: 2016-10-17 21:00:28
Also in:
linux-devicetree, lkml
Hi Alan, couple of nits inline and some comments on ordering the patches ;-) On Mon, Oct 17, 2016 at 6:09 PM, Alan Tull [off-list ref] wrote:
This patch adds a minor change in the FPGA Mangager API
s/Mangager/Manager/
to hold information that is specific to an FPGA image file. This change is expected to bring little, if any, pain. An FPGA image file will have particulars that affect how the image is programmed to the FPGA. One example is that current 'flags' currently has one bit which shows whether the FPGA image was built for full reconfiguration or partial reconfiguration. Another example is timeout values for enabling or disabling the bridges in the FPGA. As the complexity of the FPGA design increases, the bridges in the FPGA may take longer times to enable or disable.
According for the current ordering bridges are not yet defined if we merge patches in this order? Not terrible imho, but I thought I'd point it out. Would swapping the order make sense? I also think [5/10] should be squashed together with this commit to make it an atomic change. Apart from my comments above feel free to add my Acked-by Thanks for keeping this going, Moritz