[PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT matched data structure
From: Maxime Ripard <hidden>
Date: 2016-10-11 09:39:16
Also in:
dri-devel, linux-devicetree, lkml
On Tue, Oct 11, 2016 at 05:16:21PM +0800, Chen-Yu Tsai wrote:
On Fri, Oct 7, 2016 at 4:38 PM, Maxime Ripard [off-list ref] wrote:quoted
Hi, On Fri, Oct 07, 2016 at 12:06:22AM +0800, Chen-Yu Tsai wrote:quoted
+struct sun4i_tcon_quirks { + bool is_sun5i; /* sun5i has undocumented mux */ + bool has_channel_1; /* a33 does not have channel 1 */ + bool has_bypass_src; /* has separate input bypassing CEU */ + bool has_dma_src; /* has DMA input */ +}; +I'd really prefer to keep the has_mux quirk name. is_sun5i doesn't really relate to what we're doing there, is redundant with the compatible, and render the other quirks name useless, since we could just have is_sun.i quirks and deal with that (which is essentially what we were doing before).Lets call it has_unknown_mux then. has_mux would be confusing with the HDMI and MIPI DSI muxes on sun6i.
That works for me. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161011/c35796a0/attachment.sig>