Thread (2 messages) 2 messages, 2 authors, 2016-10-10

[PATCH v3 11/12] scsi/ncr5380: Use correct types for DMA routines

From: linux@armlinux.org.uk (Russell King - ARM Linux)
Date: 2016-10-10 09:19:13
Also in: linux-scsi, lkml

On Mon, Oct 10, 2016 at 12:46:53AM -0400, Finn Thain wrote:
Apply prototypes to get consistent function signatures for the DMA
functions implemented in the board-specific drivers. To avoid using
macros to alter actual parameters, some of those functions are reworked
slightly.

This is a step toward the goal of passing the board-specific routines
to the core driver using an ops struct (as in a platform driver or
library module).

This also helps fix some inconsistent types: where the core driver uses
ints (cmd->SCp.this_residual and hostdata->dma_len) for keeping track of
transfers, certain board-specific routines used unsigned long.

While we are fixing these function signatures, pass the hostdata pointer
to DMA routines instead of a Scsi_Host pointer, for shorter and faster
code.

Signed-off-by: Finn Thain <redacted>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Tested-by: Ondrej Zary <redacted>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
---
 drivers/scsi/arm/cumana_1.c | 26 ++++++++++------
 drivers/scsi/arm/oak.c      | 13 ++++----
For these two,

Acked-by: Russell King <redacted>

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help