[PATCH 2/9] pinctrl: sunxi: Add bindings define
From: Chen-Yu Tsai <hidden>
Date: 2016-10-04 01:57:37
Also in:
linux-devicetree, linux-gpio, lkml
On Mon, Oct 3, 2016 at 6:21 PM, Maxime Ripard [off-list ref] wrote:
Since we have some bindings header for our hardcoded flags, let's use them when we can.
"Use macros from bindings header file for DT parsing" would make the subject clearer. Otherwise, Acked-by: Chen-Yu Tsai <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Maxime Ripard <redacted> --- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c index 64f7f6dcc027..5be455d5e252 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c@@ -28,6 +28,8 @@ #include <linux/platform_device.h> #include <linux/slab.h> +#include <dt-bindings/pinctrl/sun4i-a10.h> + #include "../core.h" #include "../../gpio/gpiolib.h" #include "pinctrl-sunxi.h"@@ -164,9 +166,9 @@ static int sunxi_pctrl_parse_bias_prop(struct device_node *node) return -EINVAL; switch (val) { - case 1: + case SUN4I_PINCTRL_PULL_UP: return PIN_CONFIG_BIAS_PULL_UP; - case 2: + case SUN4I_PINCTRL_PULL_DOWN: return PIN_CONFIG_BIAS_PULL_DOWN; } --git-series 0.8.10