Thread (6 messages) 6 messages, 4 authors, 2016-09-30

Crash seen on ARM Juno r1 with 4.8-rc8 when Coresight is enabled

From: mathieu.poirier@linaro.org (Mathieu Poirier)
Date: 2016-09-30 00:10:52

On 29 September 2016 at 03:17, Sudeep Holla [off-list ref] wrote:

On 29/09/16 09:49, Rabin Vincent wrote:
quoted
On Wed, Sep 28, 2016 at 11:41:41AM -0600, Mathieu Poirier wrote:
[...]
quoted
quoted
Thanks you for reporting this Vankatesh,

Sudeep and Suzuki, can you guys help me with this - I don't have an R1
to test with.

I've seen this too, on other platforms.  This should fix it:

8<-----------
From a9da7d7b47e67dd6ffcafddadb50e6f97503f296 Mon Sep 17 00:00:00 2001
From: Rabin Vincent <redacted>
Date: Tue, 30 Aug 2016 08:54:21 +0200
Subject: [PATCH] coresight: check for NULL child_name

Connection child names associated to ports can sometimes be NULL, which
is the case when booting a system on QEMU or when the Coresight power
domain isn't switched on.  fadf3a44e974 ("coresight: checking for NULL
string in coresight_name_match()") fixed one place to handle this but
the same check is needed in coresight_orphan_match() to prevent a crash
there.
Thanks Rabin, we have exact same fix in linux-next already.
Sorry for the late reply - I am currently travelling.

Sudeep is correct, we have this underway for the 4.9 cycle.

Mathieu
--
Regards,
Sudeep
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help