[PATCH] tty: amba-pl011: uart_amba_port is not available with earlycon function
From: Sudeep Holla <hidden>
Date: 2016-09-20 13:15:51
Also in:
linux-serial
From: Sudeep Holla <hidden>
Date: 2016-09-20 13:15:51
Also in:
linux-serial
On 20/09/16 14:05, Shawn Guo wrote:
On Sat, Sep 17, 2016 at 02:14:38PM +0800, Shawn Guo wrote:quoted
Commit 0e125a5facf8 ("tty: amba-pl011: define flag register bits for ZTE device") changes earlycon function pl011_putc() to use a pointer to uart_amba_port. This causes a regression when earlycon is enabled, because uart_amba_port is not available yet at earlycon time. Let's revert the change on pl011_putc() to fix the regression. The earlycon support for ZTE device can probably be added later by declaring a new earlycon setup function with a vendor specific compatible. Reported-by: Sudeep Holla <redacted> Fixes: 0e125a5facf8 ("tty: amba-pl011: define flag register bits for ZTE device") Signed-off-by: Shawn Guo <redacted>Hi Sudeep, Can you please confirm if the patch fixes your problem, so that Greg knows whether it should be applied? Thanks.
Sorry, since it's basically what I tried first before posting some patch using private_data, I assumed it will work. Anyways I have now tested it, so you can add: Tested-by: Sudeep Holla <redacted> -- Regards, Sudeep