Thread (28 messages) flat view 28 messages, 2 authors, 2016-09-15

[PATCHv3 03/11] crypto: omap-sham: implement context export/import APIs

From: herbert@gondor.apana.org.au (Herbert Xu)
Date: 2016-09-01 07:20:16
Also in: linux-crypto, linux-omap

On Thu, Sep 01, 2016 at 09:56:06AM +0300, Tero Kristo wrote:
Hmm, looking at the driver, sham_update returns 0 immediately if it
just caches data. In a sense, the update is not completed at this
point. Are you saying this is illegal and can't be done?
Once you call the completion function (and returning zero from
the update itself is equivalent to calling the completion function)
the hardware must not touch the request anymore.
From my understanding, valid results are expected from the driver
only after ->final is called.
That's because you never implemented export/import :)

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help