Thread (1 message) 1 message, 1 author, 2016-09-19

[PATCH] ARM: mvebu: Select corediv clk for all mvebu v7 SoC

From: Gregory CLEMENT <hidden>
Date: 2016-09-19 14:41:16
Also in: stable

Hi Uwe,
 
 On lun., sept. 19 2016, Uwe Kleine-K?nig [off-list ref] wrote:
On Mon, Sep 19, 2016 at 01:52:07PM +0200, Gregory CLEMENT wrote:
quoted
Since the commit bd3677ff31a3 ("clk: mvebu: Remove corediv clock from
Armada XP"), the corediv clk is no more selected for Armada XP, however
this clock is used for Armada XP using the compatible
armada-370-corediv-clock.

More over even if with the commit 1594d568c6e3 ("clk: mvebu: Move corediv
config to mvebu config"), it was selected for Armada 38x and Armada 375,
it was still not selected for Armada 39x.
Instead of the above paragraph I'd write:

	While since commit 1594d568c6e3 ("clk: mvebu: Move corediv
	config to mvebu config") Armada 38x and Armada 375 got corediv
	support again, not only Armada XP was missed but also Armada
	39x.
Thanks for your suggestion I will use it.
quoted
Actually all the SoC selecting MVEBU_V7 config need this clock:
git grep "\-corediv-clock" arch/arm/boot/dts
arch/arm/boot/dts/armada-370-xp.dtsi: compatible = "marvell,armada-370-corediv-clock";
arch/arm/boot/dts/armada-375.dtsi:    compatible = "marvell,armada-375-corediv-clock";
arch/arm/boot/dts/armada-38x.dtsi:    compatible = "marvell,armada-380-corediv-clock";
arch/arm/boot/dts/armada-39x.dtsi:    compatible = "marvell,armada-390-corediv-clock"

This commit now fixes this behavior.
... by letting MVEBU_V7 select MVEBU_CLK_COREDIV.

I didn't want describe the content of the patch but I don't mind adding
it.

Thanks,

Gregory
quoted
Fixes: bd3677ff31a3 ("clk: mvebu: Remove corediv clock from Armada XP")
Cc: stable at vger.kernel.org
Reported-by: Uwe Kleine-K?nig <redacted>
Signed-off-by: Gregory CLEMENT <redacted>
BTW, I considered doing this, too, but failed to see that 39x is
missing, too, and so thought this to be wrong.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help