Thread (23 messages) 23 messages, 5 authors, 2016-10-11

[PATCH v19 05/12] fpga-mgr: add fpga image information struct

From: Michal Simek <hidden>
Date: 2016-09-29 17:43:44
Also in: linux-devicetree, lkml

On 28.9.2016 21:34, Alan Tull wrote:
On Wed, Sep 28, 2016 at 6:41 PM, Moritz Fischer
[off-list ref] wrote:
Hi Moritz,
quoted
Hi Alan,

generally ok with the change.
Cool!
quoted
On Wed, Sep 28, 2016 at 11:21 AM, Alan Tull [off-list ref] wrote:
quoted
-int fpga_mgr_buf_load(struct fpga_manager *mgr, u32 flags, const char *buf,
-                     size_t count)
+int fpga_mgr_buf_load(struct fpga_manager *mgr, struct fpga_image_info *info,
+                     const char *buf, size_t count)
Doesn't this break the both socfpga and zynq if [6/12] and [7/12] are
not part of this commit?
i.e shouldn't 5,6 and 7 be a single commit?
Yeah, squashing those would improve bisectability.
Improve? :-)

Definitely this needs to be the part of this commit.

M
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help