On Wednesday, September 14, 2016 7:48:49 PM CEST zhichang.yuan wrote:

On 2016/9/8 17:58, Arnd Bergmann wrote:

quoted

On Thursday, September 8, 2016 5:51:25 PM CEST zhichang wrote:

quoted

On 2016?09?07? 22:50, Arnd Bergmann wrote:

quoted

On Wednesday, September 7, 2016 9:33:52 PM CEST Zhichang Yuan wrote:

quoted

From: "zhichang.yuan" <redacted>

On Hip06 platform, a 16550 compatible UART is connected to low-pin-count and
controlled through the LPC I/O cycles. This patch drives the UART port with
the specific serial in/out function pair based on the indirect-IO mechanism
introduced by Hip06 LPC driver.

Signed-off-by: zhichang.yuan <redacted>

Any reason this cannot just use the regular drivers/tty/serial/8250/8250_of.c
driver?

I think two reasons for that:
1. 8250_of.c is only for devicetree, but we need to support ACPI device too;

ACPI has its own way of describing serial ports, use that instead.

Could you give me some info about ACPI serial ports?
I found there is _CRS specific for serial, but it seems no serial driver use that.

drivers/tty/serial/8250/8250_dw.c is a driver that uses ACPI matching,
and possibly drivers/tty/serial/8250/8250_pnp.c could work as well.

	Arnd