Thread (43 messages) flat view 43 messages, 4 authors, 2016-09-19

[PATCH v4 03/22] usb: ulpi: Support device discovery via DT

From: Stephen Boyd <hidden>
Date: 2016-09-12 22:05:16
Also in: linux-arm-msm, linux-devicetree, lkml

Quoting Stephen Boyd (2016-09-07 14:35:00)
quoted hunk ↗ jump to hunk
@@ -174,6 +219,21 @@ static int ulpi_register(struct device *dev, struct ulpi *ulpi)
        ulpi->id.product = ulpi_read(ulpi, ULPI_PRODUCT_ID_LOW);
        ulpi->id.product |= ulpi_read(ulpi, ULPI_PRODUCT_ID_HIGH) << 8;
 
+       /* Some ULPI devices don't have a vendor id so rely on OF match */
+       if (ulpi->id.vendor == 0)
+               goto err;
+
+       request_module("ulpi:v%04xp%04x", ulpi->id.vendor, ulpi->id.product);
+
+       return 0;
+err:
+       return of_device_request_module(&ulpi->dev);
This can't return the value of of_device_request_module() because that
returns an error if the module is builtin or if module loading is
disabled. I'll have to ignore the error here and just return success all
the time.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help