Thread (24 messages) 24 messages, 3 authors, 2016-10-11

[PATCH v8 03/16] of/numa: add nid check for memory block

From: robh+dt@kernel.org (Rob Herring)
Date: 2016-09-08 13:41:18
Also in: linux-devicetree, linux-mm, lkml

On Thu, Sep 1, 2016 at 1:54 AM, Zhen Lei [off-list ref] wrote:
quoted hunk ↗ jump to hunk
If the numa-id which was configured in memory@ devicetree node is greater
than MAX_NUMNODES, we should report a warning. We have done this for cpus
and distance-map dt nodes, this patch help them to be consistent.

Signed-off-by: Zhen Lei <redacted>
---
 drivers/of/of_numa.c | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
index 7b3fbdc..c1bd62c 100644
--- a/drivers/of/of_numa.c
+++ b/drivers/of/of_numa.c
@@ -75,6 +75,11 @@ static int __init of_numa_parse_memory_nodes(void)
                         */
                        continue;

+               if (nid >= MAX_NUMNODES) {
+                       pr_warn("NUMA: Node id %u exceeds maximum value\n", nid);
Really using pr_fmt should come first so you're not changing this
line. But not worth respinning for that:

Acked-by: Rob Herring <robh@kernel.org>

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help