Thread (35 messages) 35 messages, 4 authors, 2016-09-06

[PATCH v3 10/22] usb: chipidea: Consolidate extcon notifiers

From: Stephen Boyd <hidden>
Date: 2016-09-06 17:48:43
Also in: linux-arm-msm, lkml

On Sun, Sep 4, 2016 at 7:39 PM, Peter Chen [off-list ref] wrote:
On Fri, Sep 02, 2016 at 06:03:06PM -0700, Stephen Boyd wrote:
quoted
On Thu, Sep 1, 2016 at 8:17 PM, Peter Chen [off-list ref] wrote:
quoted
On Wed, Aug 31, 2016 at 05:40:24PM -0700, Stephen Boyd wrote:
quoted

              if (cable->state)
-                     val |= OTGSC_ID;
+                     val &= ~OTGSC_ID; /* A device */
              else
-                     val &= ~OTGSC_ID;
+                     val |= OTGSC_ID; /* B device */
One more comment, would you change the comment to "host" and "device"?
Unless we are supporting OTG-compliance device, otherwise, we should
not mention "A" or "B" for USB device.
Done
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help