Thread (24 messages) flat view 24 messages, 2 authors, 2016-08-30
STALE3659d REVIEWED: 8 (8M)

1 review trailer.

[PATCH v2 3/9] arm64: kernel: use ordinary return/argument register for el2_setup()

From: mark.rutland@arm.com (Mark Rutland)
Date: 2016-08-24 16:20:48

On Wed, Aug 24, 2016 at 04:36:00PM +0200, Ard Biesheuvel wrote:
The function el2_setup() passes its return value in register w20, and
in the two cases where the caller actually cares about this return value,
it is passed into set_cpu_boot_mode_flag() [almost] directly, which
expects its input in w20 as well.

So there is no reason to use a 'special' callee saved register here, but
we can simply follow the PCS for return value and first argument,
respectively.

Signed-off-by: Ard Biesheuvel <redacted>
Make sense to me. FWIW:

Reviewed-by: Mark Rutland <mark.rutland@arm.com>

Mark.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help