On Fri, Aug 19, 2016 at 05:45:47PM +0100, Russell King - ARM Linux wrote:

On Fri, Aug 19, 2016 at 09:44:47AM -0700, Dmitry Torokhov wrote:

quoted

On Fri, Aug 19, 2016 at 05:30:59PM +0100, Russell King wrote:

quoted

Switch the jornada720_kbd driver to use the devm_* APIs.  This is in
preparation to removing the mach/irqs.h include from this driver.

Signed-off-by: Russell King <redacted>
---
 drivers/input/keyboard/jornada720_kbd.c | 38 ++++++++-------------------------
 1 file changed, 9 insertions(+), 29 deletions(-)

diff --git a/drivers/input/keyboard/jornada720_kbd.c b/drivers/input/keyboard/jornada720_kbd.c
index 421d9c55b0e8..4b2e9ff18ba1 100644
--- a/drivers/input/keyboard/jornada720_kbd.c
+++ b/drivers/input/keyboard/jornada720_kbd.c

@@ -53,6 +53,7 @@ static unsigned short jornada_std_keymap[128] = {					/* ROW */
 struct jornadakbd {
 	unsigned short keymap[ARRAY_SIZE(jornada_std_keymap)];
 	struct input_dev *input;
+	int irq;

I do not think you need this, not in this patch and the next one does
not seem to need this either?

Can I drop this chunk?

Yes, that was accidentally left in while I was considering how to update
the driver.  It can be safely dropped.  Thanks for spotting that.

Great. I'll also drop now empty jornada720_kbd_remove() and apply.

Thanks.

-- 
Dmitry