Thread (13 messages) flat view 13 messages, 4 authors, 2016-08-30
STALE3667d

[PATCH] ARM: irq_work: Do not attempt to IPI on non IPI-capable HW

From: Peter Chen <hidden>
Date: 2016-08-17 08:28:06

 
quoted
quoted
quoted
Why not using is_smp as condition, it is more strict.

if (is_smp())
    return !!__smp_cross_call;
else
    return false;
What's the gain? We're trying to check whether we can actually
deliver an IPI. Why should we gate it by finding out whether we're smp_on_up or
not?
quoted
quoted
If UP system with CONFIG_SMP enabled, the __smp_cross_call is not
NULL, but the IPI is not capable. Or am I missing something?
Take an OMAP3 system. It is UP,  and doesn't have a GIC, so __smp_cross_call will
be NULL. Yet, it boots with a generic multi-platform kernel, with SMP on.
Are there any UP platforms which have GIC? If there is, we may be in trouble with only
depends on CONFIG_SMP.

Peter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help