Thread (26 messages) 26 messages, 5 authors, 2016-09-09
STALE3579d

[PATCH 5/8] drivers: platform: Configure dma operations at probe time

From: Sricharan <hidden>
Date: 2016-08-16 12:28:51
Also in: linux-iommu

Hi Laurent,
Hi Sricharan,

Thank you for the patch.

On Tuesday 09 Aug 2016 04:19:07 Sricharan R wrote:
quoted
Configuring DMA ops at probe time will allow deferring device probe when
the IOMMU isn't available yet.

Signed-off-by: Sricharan R <redacted>
---
 drivers/base/dd.c           | 11 +++++++++++
 drivers/base/dma-mapping.c  | 11 +++++++++++
 include/linux/dma-mapping.h |  3 +++
 3 files changed, 25 insertions(+)
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 16688f5..b9978af 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -19,6 +19,7 @@

 #include <linux/device.h>
 #include <linux/delay.h>
+#include <linux/dma-mapping.h>
 #include <linux/module.h>
 #include <linux/kthread.h>
 #include <linux/wait.h>
@@ -353,6 +354,10 @@ static int really_probe(struct device *dev, struct
device_driver *drv) if (ret)
 		goto pinctrl_bind_failed;

+	ret = dma_configure_ops(dev);
Your patch doesn't remove the of_dma_configure_ops() from
of_platform_device_create_pdata(). Unless I'm mistaken, you will then end up
configuring the DMA ops twice, which at least on ARM will be a no-op the
second time:
    I did remove both of_dmaconfigure/deconfigure from other places, but
    i did as a separate next patch [1]  (should have been squashed here).
     I will squash for the next repost.

[1] https://www.spinics.net/lists/arm-kernel/msg522510.html

Regards,
 Sricharan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help