[PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver
From: robert.jarzmik@free.fr (Robert Jarzmik)
Date: 2016-08-30 16:42:09
Also in:
linux-gpio
Possibly related (same subject, not in this thread)
- 2016-09-14 · Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver · Linus Walleij <hidden>
- 2016-09-08 · Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver · Linus Walleij <hidden>
- 2016-09-05 · Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver · Russell King - ARM Linux <linux@armlinux.org.uk>
- 2016-09-05 · Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver · Linus Walleij <hidden>
- 2016-09-04 · Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver · Linus Walleij <hidden>
Russell King - ARM Linux [off-list ref] writes:
On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote:quoted
Maybe this one would deserve a doxygen comment ?Does this solve it?
Oh yes, that's very nice, especially the "1 = in" for which I have always a doubt. Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr> I hope to have an "attempt" to test all your series on the lubbock board in the next days. The "attempt" part is because last time I checked pcmcia support was broken on lubbock (ie. CONFIG_PCMCIA_SA1111 activated implies an Oops), and I don't remember having repaired it (and it's disabled on my test farm which is a sign I was not very confident about this part). If you happen to have somewhere a branch I can pull, with all your series (at least "[RFC PATCH 00/33] SA11x0/PXA GPIO rework (Core + PCMCIA only)" and "[PATCH 0/8] SA11x0/PXA remainder & cleanups"), that would spare me the multiple git-am to make the test(s). Cheers. -- Robert