[PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver
From: robert.jarzmik@free.fr (Robert Jarzmik)
Date: 2016-08-29 19:40:02
Also in:
linux-gpio
Possibly related (same subject, not in this thread)
- 2016-09-14 · Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver · Linus Walleij <hidden>
- 2016-09-08 · Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver · Linus Walleij <hidden>
- 2016-09-05 · Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver · Russell King - ARM Linux <linux@armlinux.org.uk>
- 2016-09-05 · Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver · Linus Walleij <hidden>
- 2016-09-04 · Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver · Linus Walleij <hidden>
Hi Russell, Russell King [off-list ref] writes:
quoted hunk
Add a simple, generic, single register fixed-direction GPIO driver. This is able to support a single register where a fixed number of bits are used for input and a fixed number of bits used for output. Signed-off-by: Russell King <redacted> --- drivers/gpio/Kconfig | 6 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-reg.c | 139 +++++++++++++++++++++++++++++++++++++++++++++++ include/linux/gpio-reg.h | 12 ++++ 4 files changed, 158 insertions(+) create mode 100644 drivers/gpio/gpio-reg.c create mode 100644 include/linux/gpio-reg.hdiff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 98dd47a30fc7..49bd8b89712e 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig@@ -365,6 +365,12 @@ config GPIO_RCAR help Say yes here to support GPIO on Renesas R-Car SoCs. +config GPIO_REG + bool
So I suppose it is on purpose you forbid it to be a module. Is there a way to write either in the commit message or in the Kconfig this purpose, so that nobody on "purpose" changes this bool to tristate ?
+ help + A 32-bit single register GPIO fixed in/out implementation. This + can be used to represent any register as a set of GPIO signals.
Another question I was asking myself was how it differenciated itself from gpio-mmio, ie. what brought the need for this driver that isn't available with gpio-mmio ? I seem to understand that this is mainly for platform code, hence the "builtin only" necessity, and if I'm right a part of your cover letter could very well fit within this patch's commit message.
quoted hunk
diff --git a/drivers/gpio/gpio-reg.c b/drivers/gpio/gpio-reg.c new file mode 100644 index 000000000000..fc7e0a395f9f --- /dev/null +++ b/drivers/gpio/gpio-reg.c
...zip...
+static void gpio_reg_set_multiple(struct gpio_chip *gc, unsigned long *mask,
+ unsigned long *bits)
+{
+ struct gpio_reg *r = to_gpio_reg(gc);
+ unsigned long flags;
+
+ spin_lock_irqsave(&r->lock, flags);
+ r->out = (r->out & ~*mask) | *bits;Shouldn't this be : r->out = (r->out & ~*mask) | (*bits & *mask);
quoted hunk
diff --git a/include/linux/gpio-reg.h b/include/linux/gpio-reg.h new file mode 100644 index 000000000000..0352bec7319a --- /dev/null +++ b/include/linux/gpio-reg.h@@ -0,0 +1,12 @@ +#ifndef GPIO_REG_H +#define GPIO_REG_H + +struct device; + +struct gpio_chip *gpio_reg_init(struct device *dev, void __iomem *reg, + int base, int num, const char *label, u32 direction, u32 def_out, + const char *const *names);
Maybe this one would deserve a doxygen comment ? Cheers. -- Robert