Thread (5 messages) 5 messages, 3 authors, 2016-08-18

[PATCH] ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard

flat view

From: jacek.anaszewski@gmail.com (Jacek Anaszewski)
Date: 2016-08-18 19:47:13
Also in: linux-arm-msm, linux-leds


On 08/18/2016 03:10 PM, Linus Walleij wrote:
On Wed, Aug 17, 2016 at 11:40 PM, Jacek Anaszewski
[off-list ref] wrote:
quoted
quoted
+                               led at 48 {
+                                       /*
+                                        * The keypad LED @0x48 is routed
to
+                                        * the sensor board where it is
+                                        * connected to an infrared LED
+                                        * SFH4650 (60mW, @850nm) next to
the
+                                        * ambient light and proximity
sensor
+                                        * Capella Microsystems CM3605.
+                                        */
+                                       compatible =
"qcom,pm8058-keypad-led";
+                                       reg = <0x48>;
+                                       label = "proximity0";

In DT bindings documentation it was changed to "pm8050:white:keypad" to
adhere to the LED class device naming convention. I assume that having
it in this form is an omission here.
Hm right. Given the usecase here, what do you say about naming
it:

"pm8058:infrared:proximitysensor"
Looks good.

-- 
Best regards,
Jacek Anaszewski
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help