This adds the PM8058 LEDs as used in the platform.
Cc: linux-arm-msm at vger.kernel.org
Cc: linux-leds at vger.kernel.org
Cc: Andy Gross <redacted>
Cc: Stephen Boyd <redacted>
Cc: Bjorn Andersson <redacted>
Cc: Jacek Anaszewski <redacted>
Signed-off-by: Linus Walleij <redacted>
---
These DT bindings have been ACKed by Rob Herring and Bjorn Andersson
so I think the patch is safe to merge to the Qcom tree.
---
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 39 ++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
On Tue 16 Aug 12:45 PDT 2016, Linus Walleij wrote:
This adds the PM8058 LEDs as used in the platform.
Cc: linux-arm-msm at vger.kernel.org
Cc: linux-leds at vger.kernel.org
Cc: Andy Gross <redacted>
Cc: Stephen Boyd <redacted>
Cc: Bjorn Andersson <redacted>
Cc: Jacek Anaszewski <redacted>
Signed-off-by: Linus Walleij <redacted>
---
These DT bindings have been ACKed by Rob Herring and Bjorn Andersson
so I think the patch is safe to merge to the Qcom tree.
---
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 39 ++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
From: Jacek Anaszewski <jacek.anaszewski@gmail.com> Date: 2016-08-17 21:40:32
On 08/16/2016 09:45 PM, Linus Walleij wrote:
quoted hunk
This adds the PM8058 LEDs as used in the platform.
Cc: linux-arm-msm at vger.kernel.org
Cc: linux-leds at vger.kernel.org
Cc: Andy Gross <redacted>
Cc: Stephen Boyd <redacted>
Cc: Bjorn Andersson <redacted>
Cc: Jacek Anaszewski <redacted>
Signed-off-by: Linus Walleij <redacted>
---
These DT bindings have been ACKed by Rob Herring and Bjorn Andersson
so I think the patch is safe to merge to the Qcom tree.
---
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 39 ++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
In DT bindings documentation it was changed to "pm8050:white:keypad" to
adhere to the LED class device naming convention. I assume that having
it in this form is an omission here.
quoted hunk
+ default-state = "off";+ };+ led at 131 {+ compatible = "qcom,pm8058-led";+ reg = <0x131>;+ label = "pm8058:red";+ default-state = "off";+ };+ led at 132 {+ /*+ * This is actually green too on my+ * board, but documented as yellow.+ */+ compatible = "qcom,pm8058-led";+ reg = <0x132>;+ label = "pm8058:yellow";+ default-state = "off";+ linux,default-trigger = "mmc0";+ };+ led at 133 {+ compatible = "qcom,pm8058-led";+ reg = <0x133>;+ label = "pm8058:green";+ default-state = "on";+ linux,default-trigger = "heartbeat";+ }; }; };
On Wed, Aug 17, 2016 at 11:40 PM, Jacek Anaszewski
[off-list ref] wrote:
quoted
+ led at 48 {
+ /*
+ * The keypad LED @0x48 is routed
to
+ * the sensor board where it is
+ * connected to an infrared LED
+ * SFH4650 (60mW, @850nm) next to
the
+ * ambient light and proximity
sensor
+ * Capella Microsystems CM3605.
+ */
+ compatible =
"qcom,pm8058-keypad-led";
+ reg = <0x48>;
+ label = "proximity0";
In DT bindings documentation it was changed to "pm8050:white:keypad" to
adhere to the LED class device naming convention. I assume that having
it in this form is an omission here.
Hm right. Given the usecase here, what do you say about naming
it:
"pm8058:infrared:proximitysensor"
?
Yours,
Linus Walleij
From: Jacek Anaszewski <jacek.anaszewski@gmail.com> Date: 2016-08-18 19:47:13
On 08/18/2016 03:10 PM, Linus Walleij wrote:
On Wed, Aug 17, 2016 at 11:40 PM, Jacek Anaszewski
[off-list ref] wrote:
quoted
quoted
+ led at 48 {
+ /*
+ * The keypad LED @0x48 is routed
to
+ * the sensor board where it is
+ * connected to an infrared LED
+ * SFH4650 (60mW, @850nm) next to
the
+ * ambient light and proximity
sensor
+ * Capella Microsystems CM3605.
+ */
+ compatible =
"qcom,pm8058-keypad-led";
+ reg = <0x48>;
+ label = "proximity0";
In DT bindings documentation it was changed to "pm8050:white:keypad" to
adhere to the LED class device naming convention. I assume that having
it in this form is an omission here.
Hm right. Given the usecase here, what do you say about naming
it:
"pm8058:infrared:proximitysensor"