Thread (8 messages) flat view 8 messages, 3 authors, 2016-08-31

[PATCH] drm/sun4i: Clear encoder->bridge if a bridge is not found

From: Maxime Ripard <hidden>
Date: 2016-08-31 16:43:05
Also in: dri-devel, lkml

On Wed, Aug 31, 2016 at 06:27:08PM +0200, Daniel Vetter wrote:
quoted
quoted
quoted
quoted
+     if (IS_ERR(encoder->bridge))
+             encoder->bridge = NULL;
+
And that could be the else condition of the if statement below.
That would be a bit confusing, changing it after calling drm_encoder_init.
The code says it ok to do though.
The magic really happens only after the encoder has been attached to
something, so it's really safe.
s/attached/registered using drm_dev_register(). Which should
happen _way_ later for all drivers which have gotten rid of their ->load
callback and implemented the recommend driver load sequence.
My bad, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160831/39904c8d/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help