[PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes
From: Lee Jones <hidden>
Date: 2016-08-30 10:00:12
Also in:
dri-devel, linux-devicetree, linux-remoteproc, lkml
On Fri, 26 Aug 2016, Peter Griffin wrote:
quoted hunk ↗ jump to hunk
This patch adds the DT node for the uniperif reader IP block found on STiH407 family silicon. Signed-off-by: Arnaud Pouliquen <redacted> Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi index d263c96..bdddf2c 100644 --- a/arch/arm/boot/dts/stih407-family.dtsi +++ b/arch/arm/boot/dts/stih407-family.dtsi@@ -956,5 +956,31 @@ st,version = <5>; st,mode = "SPDIF"; }; + + sti_uni_reader0: sti-uni-reader at 0 { + compatible = "st,sti-uni-reader"; + status = "disabled";
I find it's normally nicer to place the status of the node at the bottom, separated by a '\n'. There isn't a functional difference admittedly, but it would be my preference, since it's not describing the device per se.
+ #sound-dai-cells = <0>; + st,syscfg = <&syscfg_core>; + reg = <0x8D83000 0x158>;
We usually use lower-case for the address. Since this has a 'reg' property, the '0' in the node name does not look appropriate.
+ interrupts = <GIC_SPI 87 IRQ_TYPE_NONE>; + dmas = <&fdma0 5 0 1>; + dma-names = "rx"; + dai-name = "Uni Reader #0 (PCM IN)";
Oooo, not seen something like this before. If it does not already have one, it would require a DT Ack.
+ st,version = <3>;
This will likely need a DT Ack too. We usually encode this sort of information in the compatible string.
+ };
+
+ sti_uni_reader1: sti-uni-reader at 1 {
+ compatible = "st,sti-uni-reader";
+ status = "disabled";
+ #sound-dai-cells = <0>;
+ st,syscfg = <&syscfg_core>;
+ reg = <0x8D84000 0x158>;
+ interrupts = <GIC_SPI 88 IRQ_TYPE_NONE>;
+ dmas = <&fdma0 6 0 1>;
+ dma-names = "rx";
+ dai-name = "Uni Reader #1 (HDMI RX)";
+ st,version = <3>;
+ };All as above.
}; };
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog