Thread (11 messages) 11 messages, 2 authors, 2016-08-23

[PATCH v7 6/7] power: act8945a_charger: Add max current property

From: sre@kernel.org (Sebastian Reichel)
Date: 2016-08-23 02:43:59
Also in: linux-devicetree, linux-pm, lkml

Hi,

On Mon, Aug 22, 2016 at 02:49:16PM +0800, Wenyou Yang wrote:
[...]

-	chglev_pin = of_get_named_gpio_flags(np,
-				"active-semi,chglev-gpios", 0, &flags);
-
-	if (gpio_is_valid(chglev_pin)) {
-		gpio_set_value(chglev_pin,
-			       ((flags == OF_GPIO_ACTIVE_LOW) ? 0 : 1));
+	charger->chglev_gpio = gpiod_get(dev->parent,
+					 "active-semi,chglev", GPIOD_IN);
+	if (PTR_ERR(charger->chglev_gpio) == -EPROBE_DEFER) {
+		dev_info(dev, "probe retry requested for gpio \"chglev\"\n");
missing return? You need to return EPROBE_DEFER in probe().
+	} else if (IS_ERR(charger->chglev_gpio)) {
+		dev_err(dev, "unable to claim gpio \"chglev\"\n");
+		charger->chglev_gpio = NULL;
 	}
 
[...]
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160823/f6c2d445/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help