On Tue, Jun 7, 2016 at 11:55 AM, Javier Martinez Canillas
[off-list ref] wrote:

On 06/07/2016 02:50 PM, Javier Martinez Canillas wrote:

quoted

Hello Stephen,

On Wed, Jun 1, 2016 at 7:15 PM, Stephen Boyd [off-list ref] wrote:

quoted

Now that we have clk_hw based provider APIs to register clks, we
can get rid of struct clk pointers while registering clks in
these drivers, allowing us to move closer to a clear split of
consumer and provider clk APIs.

Cc: Javier Martinez Canillas <redacted>

This email address doesn't exist anymore, you can use
javier at osg.samsung.com instead.

quoted

Signed-off-by: Stephen Boyd <redacted>
---

See commit 58657d189a2f and it's children for details on this
new registration API.

I tried this patch on top of linux-next and my Peach Pi Chromebook
(that has a max77802 chip) failed to boot. Following is the relevant
parts from the boot log:

It seems the mailer did a mess with the line wrapping so here's another attempt:

Thanks! Found the problem too.

----8<-----

diff --git a/drivers/clk/clk-max-gen.c b/drivers/clk/clk-max-gen.c
index 4bb53fcf8639..5e8bac190698 100644
--- a/drivers/clk/clk-max-gen.c
+++ b/drivers/clk/clk-max-gen.c

@@ -169,7 +169,7 @@ int max_gen_clk_probe(struct platform_device

*pdev, struct regmap *regmap,

        if (dev->of_node) {
                ret = of_clk_add_hw_provider(dev->of_node, of_clk_max_gen_get,
-                                            max_gen_clks);
+                                            max_gen_data);
                if (ret) {
                        dev_err(dev, "failed to register OF clock provider\n");
                        return ret;