[PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver

On 08/16, Neil Armstrong wrote:

On 08/13/2016 03:29 AM, Stephen Boyd wrote:

quoted

On 08/09, Neil Armstrong wrote:

quoted

quoted

+
+static struct clk_hw_onecell_data gxbb_aoclk_onecell_data = {

can this be const?

It would be awesome, but it will be discarded by of_clk_add_hw_provider :

Ok, right.

quoted

quoted

+iounmap:
+	iounmap(base);
+	return ret;
+}
+
+static const struct of_device_id gxbb_aoclkc_match_table[] = {
+	{ .compatible = "amlogic,gxbb-aoclkc" },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, gxbb_aoclkc_match_table);
+
+static struct platform_driver gxbb_aoclkc_driver = {
+	.probe		= gxbb_aoclkc_probe,

No remove means leak of iomem mapping.

And OF provider registration.

quoted

It will be non-modular, so no need of remove. The MODULE_* macros and module.h include will be removed like other clk drivers (gxbb and oxnas for instance).

Ok make sure to remove sysfs unbinding then.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project