Thread (12 messages) flat view 12 messages, 3 authors, 2016-08-15

[PATCH v3 4/4] arm64: apply __ro_after_init to some objects

From: mark.rutland@arm.com (Mark Rutland)
Date: 2016-08-15 09:09:33
Also in: lkml

Hi,

On Mon, Aug 15, 2016 at 02:53:03PM +0800, Jisheng Zhang wrote:
On Fri, 12 Aug 2016 13:43:45 +0100 Mark Rutland wrote:
quoted
On Fri, Aug 12, 2016 at 04:01:11PM +0800, Jisheng Zhang wrote:
quoted
diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c
index 10ad8ab..c1ff7c2 100644
--- a/arch/arm64/kernel/vdso.c
+++ b/arch/arm64/kernel/vdso.c
@@ -19,6 +19,7 @@
  */
 
 #include <linux/kernel.h>
+#include <linux/cache.h>
 #include <linux/clocksource.h>
 #include <linux/elf.h>
 #include <linux/err.h>  
Nit: Could you please sort this list? Everything but <linux/kernel.h> is
already in order.
[...]
Thanks a lot, all comments are addressed in v4.

the headers in vdso.c is sorted now. However, the headers in mmu.c,
dma-mapping.c, init.c aren't, for I dunno whether it's acceptable
to do so. Or we could add one separate patch to make them sorted before
applying __ro_after_init
Ah. Given that's a little messy, it's probably not worthwhile sorting them.
Further, feel free to not bother sorting the vdso.c includes.

Thanks,
Mark.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help