[PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq

Subsystems: the rest

STALE3675d

5 messages, 3 authors, 2016-08-15 · open the first message on its own page

[PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq

From: Joshua Clayton <hidden>
Date: 2016-08-11 16:54:14

Apply hardware workaround for ethernet problem
See nxp erratum err006687

Signed-off-by: Joshua Clayton <redacted>
---
 arch/arm/boot/dts/imx6q-evi.dts | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/imx6q-evi.dts b/arch/arm/boot/dts/imx6q-evi.dts
index 49c6f61..33bd04b 100644
--- a/arch/arm/boot/dts/imx6q-evi.dts
+++ b/arch/arm/boot/dts/imx6q-evi.dts
@@ -127,6 +127,8 @@
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii";
 	phy-reset-gpios = <&gpio1 25 0>;
+	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
+			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
 	status = "okay";
 };
 
@@ -312,6 +314,7 @@
 			MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b0b0
 			MX6QDL_PAD_ENET_TX_EN__ENET_TX_EN 0x4001b0a8
 			MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1b0b0
+			MX6QDL_PAD_GPIO_6__ENET_IRQ 0x000b1
 		>;
 	};
 
-- 
2.7.4

Re: [PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq

From: Stefan Wahren <hidden>
Date: 2016-08-11 17:09:45

Hi Joshua,
Joshua Clayton [off-list ref] hat am 11. August 2016 um 18:54
geschrieben:


Apply hardware workaround for ethernet problem
See nxp erratum err006687
do you know this commit?

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a28eeb43ee57e0524c59e64760ed28088dd159cb

Maybe you want to add this property, too.

Re: [PATCH 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq

From: Joshua Clayton <hidden>
Date: 2016-08-11 17:24:26

Stefan,

On 08/11/2016 10:09 AM, Stefan Wahren wrote:
Hi Joshua,
quoted
Joshua Clayton [off-list ref] hat am 11. August 2016 um 18:54
geschrieben:


Apply hardware workaround for ethernet problem
See nxp erratum err006687
do you know this commit?

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a28eeb43ee57e0524c59e64760ed28088dd159cb

Maybe you want to add this property, too.
I missed that this change requiring (more) explicit enablement was merge to linux-next.
I'll add that.

[PATCH V2 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq

From: Joshua Clayton <hidden>
Date: 2016-08-11 17:35:25

Apply hardware workaround for ethernet problem
See nxp erratum err006687

Signed-off-by: Joshua Clayton <redacted>
---

Changed since V1:
- added fsl,err006687-workaround-present; so that it will continue to work

 arch/arm/boot/dts/imx6q-evi.dts | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/imx6q-evi.dts b/arch/arm/boot/dts/imx6q-evi.dts
index 49c6f61..33bd04b 100644
--- a/arch/arm/boot/dts/imx6q-evi.dts
+++ b/arch/arm/boot/dts/imx6q-evi.dts
@@ -127,6 +127,8 @@
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii";
 	phy-reset-gpios = <&gpio1 25 0>;
+	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
+			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
+	fsl,err006687-workaround-present;
 	status = "okay";
 };
 
@@ -312,6 +314,7 @@
 			MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b0b0
 			MX6QDL_PAD_ENET_TX_EN__ENET_TX_EN 0x4001b0a8
 			MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1b0b0
+			MX6QDL_PAD_GPIO_6__ENET_IRQ 0x000b1
 		>;
 	};
 
-- 
2.7.4

Re: [PATCH V2 1/1] ARM: dts: imx6q-evi: Use GPIO_6 for fec irq

From: Shawn Guo <shawnguo@kernel.org>
Date: 2016-08-15 14:31:00

On Thu, Aug 11, 2016 at 10:35:16AM -0700, Joshua Clayton wrote:
Apply hardware workaround for ethernet problem
See nxp erratum err006687

Signed-off-by: Joshua Clayton <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help