Thread (7 messages) flat view 7 messages, 3 authors, 2016-09-01

[PATCH 1/3] net: stmmac: dwmac-rk: add rk3366 & rk3399 specific data

From: heiko@sntech.de (Heiko Stübner)
Date: 2016-08-11 08:13:10
Also in: linux-devicetree, linux-rockchip, lkml, netdev

Hi Roger,

Am Donnerstag, 11. August 2016, 15:24:46 schrieb Roger Chen:
quoted hunk ↗ jump to hunk
Add constants and callback functions for the dwmac on rk3228/rk3229 socs.
As can be seen, the base structure is the same, only registers and the
bits in them moved slightly.

Signed-off-by: Roger Chen <redacted>
---
 .../devicetree/bindings/net/rockchip-dwmac.txt     |   4 +-
 drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c     | 226
+++++++++++++++++++++ 2 files changed, 228 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.txt
b/Documentation/devicetree/bindings/net/rockchip-dwmac.txt index
cccd945..8c066e6 100644
--- a/Documentation/devicetree/bindings/net/rockchip-dwmac.txt
+++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.txt
@@ -3,8 +3,8 @@ Rockchip SoC RK3288 10/100/1000 Ethernet driver(GMAC)
 The device node has following properties.

 Required properties:
- - compatible: Can be one of "rockchip,rk3228-gmac",
"rockchip,rk3288-gmac", -                            
"rockchip,rk3368-gmac"
+ - compatible: Can be one of "rockchip,rk3288-gmac",
you're dropping the rk3228 here.

Otherwise looks fine, so with the compatible list fixed you can add my
Reviewed-by: Heiko Stuebner <heiko@sntech.de>


Heiko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help