[PATCH 2/2] arm: apply more __ro_after_init
From: linux@armlinux.org.uk (Russell King - ARM Linux)
Date: 2016-08-10 18:22:31
Also in:
linux-arch, lkml
On Fri, Jun 03, 2016 at 11:40:24AM -0700, Kees Cook wrote:
quoted hunk ↗ jump to hunk
@@ -1309,16 +1309,11 @@ void __init arm_mm_memblock_reserve(void) * Any other function or debugging method which may touch any device _will_ * crash the kernel. */ +static char vectors[PAGE_SIZE * 2] __ro_after_init __aligned(PAGE_SIZE); static void __init devicemaps_init(const struct machine_desc *mdesc) { struct map_desc map; unsigned long addr; - void *vectors; - - /* - * Allocate the vector page early. - */ - vectors = early_alloc(PAGE_SIZE * 2);
This one is not appropriate. We _do_ write to these pages after init for FIQ handler updates. See set_fiq_handler(). -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.