On Thu, Aug 04, 2016 at 05:57:48PM -0700, Stephen Boyd wrote:

On 07/11, Andy Gross wrote:

quoted

On Mon, Jul 11, 2016 at 02:50:08PM -0700, Stephen Boyd wrote:

quoted

The voltage ranges listed here are wrong. The pma8084 pldo
supports three different overlapping voltage ranges with
differing step sizes and the pma8084 ftsmps supports two. These
ranges can be seen in the "native" spmi regulator driver
(qcom_spmi-regulator.c) at pldo_ranges[] and ftsmps_ranges[]
respectively. Port these ranges over to the RPM SMD regulator
driver so that we list the appropriate set of supported voltages
on these types of regulators.

Cc: Andy Gross <redacted>
Cc: Bjorn Andersson <redacted>
Fixes: ee01d0c91ef1 ("regulator: qcom-smd: Add support for PMA8084")
Signed-off-by: Stephen Boyd <redacted>

<snip>

quoted

 static const struct regulator_desc pma8084_pldo = {
 	.linear_ranges = (struct regulator_linear_range[]) {
-		REGULATOR_LINEAR_RANGE(750000,  0,  30, 25000),
-		REGULATOR_LINEAR_RANGE(1500000, 31, 99, 50000),
+		REGULATOR_LINEAR_RANGE( 750000,  0,  63, 12500),

It was my understanding that the PMOS ldos only support 25mV and 50mV
incremements.

Unfortunately that isn't true. It also supports 12.5mV steps for
the lower voltage ranges.

Ok. with that resolved:

Reviewed-by: Andy Gross <redacted>