[PATCH 2/5] ARM: OMAP2+: hwmod: fetch main_clk based on hwmod name
From: tony@atomide.com (Tony Lindgren)
Date: 2016-07-04 06:54:29
Also in:
linux-omap
From: tony@atomide.com (Tony Lindgren)
Date: 2016-07-04 06:54:29
Also in:
linux-omap
Hi, * Tero Kristo [off-list ref] [160630 06:18]:
With the transition to hwmod module clocks, all hwmods will have their main clocks named <hwmod_name>_mod_ck. Use this info to fetch main_clk, and use it if found.
..
static int _init_main_clk(struct omap_hwmod *oh)
{
int ret = 0;
+ char name[32];
+ static int max_len;
+ struct clk *clk;
- if (!oh->main_clk)
- return 0;
+ strcpy(name, oh->name);
+ strcat(name, "_mod_ck");
+
+ if (strlen(name) > max_len)
+ max_len = strlen(name);Just noticed that this needs some improvments to avoid nasty bugs early on. You don't seem to have max_len defined, and you should do a strncpy using #define MOD_CLK_MAX_LEN (32 + 7) or something similar instead of the strcpy and leave room for the strcat. Care to update and repost just this one? Regards, Tony