31.07.2016, 20:39, "Amit Tomer" [off-list ref]:

Hello ,

quoted

?@@ -264,6 +266,12 @@ static int sun4i_usb_phy_init(struct phy *_phy)
?????????????????val = readl(phy->pmu + REG_PMU_UNK_H3);
?????????????????writel(val & ~2, phy->pmu + REG_PMU_UNK_H3);
?????????} else {
?+ /* A64 needs also this unknown bit */
?+ if (data->cfg->type == sun50i_a64_phy) {
?+ val = readl(phy->pmu + REG_PMU_UNK_H3);
?+ writel(val & ~2, phy->pmu + REG_PMU_UNK_H3);
?+ }
?+

This bit is also set for H3, shall we reuse it or we should enclose it
in else-if part ?

To be honest, I don't know which format is better...
I'm not so familiar about the tradition of Linux kernel coding style...

Thanks
Amit.