[PATCH] arm: dts: sun7i-a20-bananapi: name the GPIO lines
From: Linus Walleij <hidden>
Date: 2016-07-25 13:27:55
Also in:
linux-devicetree
Possibly related (same subject, not in this thread)
- 2016-08-05 · [PATCH] arm: dts: sun7i-a20-bananapi: name the GPIO lines · Oleksij Rempel <hidden>
- 2016-07-25 · Re: [PATCH] arm: dts: sun7i-a20-bananapi: name the GPIO lines · fixed-term.Oleksij.Rempel <hidden>
- 2016-07-22 · Re: [PATCH] arm: dts: sun7i-a20-bananapi: name the GPIO lines · Chen-Yu Tsai <hidden>
- 2016-07-22 · Re: [PATCH] arm: dts: sun7i-a20-bananapi: name the GPIO lines · Linus Walleij <hidden>
- 2016-07-14 · [PATCH] arm: dts: sun7i-a20-bananapi: name the GPIO lines · Oleksij Rempel <hidden>
On Mon, Jul 25, 2016 at 7:27 AM, fixed-term.Oleksij.Rempel [off-list ref] wrote:
On 22.07.2016 17:47, Chen-Yu Tsai wrote:quoted
On Fri, Jul 22, 2016 at 10:55 PM, Linus Walleij [off-list ref] wrote:
quoted
quoted
"LED1" seems like the right name, if this is a GPIO used to drive a LED.This is GPIO based.This was not clear to me, marking GPIO pin as peripheral, at moment of writing and testing it was a allocated by led driver. Bit for example IO-GCLK was free to use for GPIO :).. so do [] actually make sense?
I would say if the hardware is used in GPIO mode, i.e. if the hardware registers of the GPIO block is written to activate the LED, then it is "LED1". If there would be a specific LED driver block that disables the GPIO block to be used for the same lines and have its registers elsewhere, it would be "[LED1]". So proper names "FOO" is for the case where the GPIO output is used as GPIO. Yours, Linus Walleij