[PATCH v3 2/7] bindings: spi-samsung: document the clocks and the clock-name property
From: robh@kernel.org (Rob Herring)
Date: 2016-07-16 20:30:44
Also in:
linux-clk, linux-devicetree, linux-samsung-soc, linux-spi
On Tue, Jul 12, 2016 at 07:02:11PM +0900, Andi Shyti wrote:
quoted hunk ↗ jump to hunk
These two properties were not documented but used in the spi dts. Add the related documentation. Suggested-by: Krzysztof Kozlowski <redacted> Signed-off-by: Andi Shyti <redacted> Reviewed-by: Michael Turquette <mturquette@baylibre.com> Reviewed-by: Krzysztof Kozlowski <redacted> --- Documentation/devicetree/bindings/spi/spi-samsung.txt | 9 +++++++++ 1 file changed, 9 insertions(+)diff --git a/Documentation/devicetree/bindings/spi/spi-samsung.txt b/Documentation/devicetree/bindings/spi/spi-samsung.txt index 57d5539..f45c6eb 100644 --- a/Documentation/devicetree/bindings/spi/spi-samsung.txt +++ b/Documentation/devicetree/bindings/spi/spi-samsung.txt@@ -24,6 +24,15 @@ Required SoC Specific Properties: - dma-names: Names for the dma channels. There must be at least one channel named "tx" for transmit and named "rx" for receive. +- clocks: specifies the clock IDs provided to the SPI controller; they are + required for interacting with the controller itself, for synchronizing the bus + and as I/O clock (the latter is required by exynos5433 and exynos7). + +- clock-names: string names of the clocks in the 'clocks' property; for all the + the devices the names must be "spi", "spi_busclkN" (where N is determined by + "samsung,spi-src-clk"), while Exynos5433 should specify a third clock
This sounds like you are describing the configuration of the clocks, not the connections. The binding here should list clocks for all possible vaules of N as those are all the input clocks to the block.
+ "spi_ioclk" for the I/O clock. + Required Board Specific Properties: - #address-cells: should be 1. -- 2.8.1