[PATCH] ARM: dts: armada-388-clearfog: remove duplicate mdio entry

On Sun, Jul 10, 2016 at 11:38:04PM +0100, Russell King - ARM Linux wrote:

On Mon, Jul 11, 2016 at 12:27:43AM +0200, Andrew Lunn wrote:

quoted

On Sun, Jul 10, 2016 at 09:45:46PM +0100, Russell King - ARM Linux wrote:

quoted

On Sun, Jul 10, 2016 at 10:37:51PM +0200, Andrew Lunn wrote:

quoted

The armada-38x.dtsi has

                                ref_clk0_pins: ref-clk-pins-0 {
                                        marvell,pins = "mpp45";
                                        marvell,function = "ref";
                                };

which you could reference rather then defining it yourself.

Weren't these going to be deleted from the main SoC dtsi files,
eventually?  I thought that was the idea, to prevent cluttering
up the .dtb files with nodes which aren't ever used.

I've not heard they are going to be removed....

Having work on mvebu, and a Freescale Vybrid board, i see two
different styles. mvebu defines all the common pinctrl values in the
.dtsi file, so making the .dts file pretty minimalist. For the vybrid
board there was nothing in the .dtsi file, the dts file is huge, and i
made at least one error, missing at required pin which took me a while
to debug.

I would also say cluttered .dtb because of unused nodes it a compiler
issue. Why does it not optimise them out?

How does it know that the pinmux nodes (which are nodes in their own
right, just like any node specifying a real device) are "unused" ?

Yes, you are right. A phandle pointing to it shows it is used, but not
being references via a phandle does not mean it is unused.

      Andrew