[linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm, nvram_file_name dt property
From: arnd@arndb.de (Arnd Bergmann)
Date: 2016-07-02 21:30:21
Also in:
linux-devicetree, linux-wireless
From: arnd@arndb.de (Arnd Bergmann)
Date: 2016-07-02 21:30:21
Also in:
linux-devicetree, linux-wireless
On Saturday, July 2, 2016 8:20:35 PM CEST Arend Van Spriel wrote:
quoted
If you want a separate property, then I repeat my very first suggestion, the well defined model property. e.g. brcmf at 0 { model = "ampak,ap6210"; compatible = "brcm,bcm4329-fmac"; ... }; All device nodes may have a model property, not just the top "machine" one.I heard you the first time I just was not sure what the implications would be to use it. Hence I suggested a vendor specific property. However, looking up and reading the definition in ePAPRv1.1 I suppose it is fine to use the model property: Property: model Value type: <string> Description: The model property value is a <string> that specifies the manufacturer?s model number of the device. The recommended format is: ?manufacturer,model?, where manufacturer is a string describing the name of the manufacturer (such as a stock ticker symbol), and model specifies the model number.
The model property is very similar to compatible, except that there is only one entry rather than a list of entries from most specific to most generic. I think by writing the above example as compatible = "ampak,ap6210", "brcm,bcm4329-fmac"; we can provide the same functionality in a slightly simpler way, the driver then just goes on to look for the nvram file for each entry in sequence until it finds one. Arnd