On Mon, Jul 25, 2016 at 10:03:14AM +0200, Michal Suchanek wrote:

Hello,

On 25 July 2016 at 09:32, Maxime Ripard
[off-list ref] wrote:

quoted

On Fri, Jun 17, 2016 at 12:34:44PM +0200, Michal Suchanek wrote:

quoted

Hello,

On 13 June 2016 at 21:57, Maxime Ripard
[off-list ref] wrote:

quoted

On Mon, Jun 13, 2016 at 05:46:48PM -0000, Michal Suchanek wrote:

quoted

Hello,

This is update of the sunxi spi patches that should give full-featured SPI
driver.

First three patches fix issues with the current driver and can be of use for
stable kernels so adding cc for those.

I merged the sun4i and sun6i driver because there several issues that need to
be fixed in both separately and they are even out of sync wrt some fixes.
I guess some of the merge patches can be squashed.

I tested this with A10s Olinuxino Micro. I have no sun6i device so I cannot
tell if that side was broken by this patchset - especially the last patch that
adds DMA was afaik never tested on sun6i.

For the record, I'm still very much opposed to such a merge.

What is the reason against the merge? I did not find the original
discussion.

I really prefer some code that is concise and clear but a little
duplicated over some code that shares every possible lines of code but
is a giant mess impossible to understand.

Yes, it's been tried. In the case of this driver there is more duplication
than differences. Also bitrot due to different variants receiving different
updates and fixes crept in already.

Adding the remap layer certainly does not make the driver easier to
understand but it's not becoming giant mess either.

Well, when you say that you're not quite fond of using your structure
all over the place because "it makes your eyes bleed", I wouldn't call
that a good sales pitch.

But again, reg_field seems like a good solution for that.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160729/3298104f/attachment.sig>