Thread (31 messages) 31 messages, 4 authors, 2016-07-28

[PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables

From: Jean-Francois Moine <hidden>
Date: 2016-07-27 08:36:59
Also in: linux-clk, linux-devicetree, lkml

On Wed, 27 Jul 2016 09:40:20 +0200
Maxime Ripard [off-list ref] wrote:
quoted
quoted
Parenting functions would also not work as expected,
clk_hw_get_parent_by_index being the obvious example, in that case
returning the empty string for an invalid parent, while it should
really return NULL.
I don't see why the clock should be orphan.
Then, when a parent is "", clk_hw_get_parent_by_index() returns NULL.
Why? It should return NULL when there's no parent, while you
explicitly registered a parent.
"" is not an existing parent. It could be "none" / "dum" / "toto" / ...
with the same result: 'this index cannot be used in mux'.

-- 
Ken ar c'henta?	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help