[PATCH v3 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node
From: linux@armlinux.org.uk (Russell King - ARM Linux)
Date: 2016-07-21 09:15:20
Also in:
linux-devicetree, linux-pm, lkml
On Wed, Jul 20, 2016 at 05:40:28PM +0800, Peter Chen wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 69426e6..0d05812 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c@@ -914,6 +914,16 @@ static int ci_hdrc_probe(struct platform_device *pdev) if (!ci) return -ENOMEM; + /* + * At device tree, we have no device node for chipidea core, + * the glue layer's node is the parent node for host and udc + * device. But in related driver, the parent device is chipidea + * core. So, in order to let the common driver get parent's node, + * we let the core's device node equals glue layer's node. + */ + if (dev->parent && dev->parent->of_node) + dev->of_node = dev->parent->of_node;
This is a dangerous thing to do. You're changing the dev->of_node of _this_ device, which means that _this_ driver will no longer match the device if you remove and reinsert the driver module, or unbind and try to re-bind the device to this driver. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.