[PATCH] arm64: dts: rockchip: add spiX aliases for rk3399
From: heiko@sntech.de (Heiko Stübner)
Date: 2016-07-19 18:56:59
Also in:
linux-devicetree, linux-rockchip, lkml
Hi Uwe, Am Dienstag, 19. Juli 2016, 08:39:55 schrieb Uwe Kleine-K?nig:
On Thu, Jul 14, 2016 at 06:24:33PM -0700, Brian Norris wrote:quoted
It's nicer to see this: # ls -l /sys/bus/spi/devices/ total 0 lrwxrwxrwx 1 root root 0 Dec 31 1969 spi0.0 -> ../../../devices/platform/ff1c0000.spi/spi_master/spi0/spi0.0 lrwxrwxrwx 1 root root 0 Dec 31 1969 spi1.0 -> ../../../devices/platform/ff1d0000.spi/spi_master/spi1/spi1.0 lrwxrwxrwx 1 root root 0 Dec 31 1969 spi2.0 -> ../../../devices/platform/ff1e0000.spi/spi_master/spi2/spi2.0 lrwxrwxrwx 1 root root 0 Dec 31 1969 spi5.0 -> ../../../devices/platform/ff200000.spi/spi_master/spi5/spi5.0> than this: # ls -l /sys/bus/spi/devices/ total 0 lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32763.0 -> ../../../devices/platform/ff200000.spi/spi_master/spi32763/spi32763.0 lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32764.0 -> ../../../devices/platform/ff1e0000.spi/spi_master/spi32764/spi32764.0 lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32765.0 -> ../../../devices/platform/ff1d0000.spi/spi_master/spi32765/spi32765.0 lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32766.0 -> ../../../devices/platform/ff1c0000.spi/spi_master/spi32766/spi32766.0> With the latter, it's much clearer which bus devices are on. Signed-off-by: Brian Norris <briannorris@chromium.org> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsib/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 4c84229789ef..b04abbfd4898 100644--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi@@ -70,6 +70,12 @@ serial2 = &uart2; serial3 = &uart3; serial4 = &uart4; + spi0 = &spi0; + spi1 = &spi1; + spi2 = &spi2; + spi3 = &spi3; + spi4 = &spi4; + spi5 = &spi5;Note that Rob Herring (with his dt-maintainer hat on) doesn't like these aliases. See for example: http://mid.gmane.org/20160705140546.GA10601 at rob-hp-laptop
thanks for the heads up on this. I've dropped this patch again. Thanks Heiko