On 18/07/2016 15:25, Jonathan Cameron wrote:

On 15/07/16 10:59, Quentin Schulz wrote:

quoted

The Allwinner SoCs all have an ADC that can also act as a touchscreen
controller and a thermal sensor. For now, only the ADC and the thermal
sensor drivers are probed by the MFD, the touchscreen controller support
will be added later.

Signed-off-by: Quentin Schulz <redacted>

Hmm. Previous patch includes the header this one creates.  Ordering issue?
The depends kind of prevents build failures by ensuring that can't be built
until this one is in place, but it is certainly an ugly way to do it.

Few little bits innline.

[...]

quoted

+static int sunxi_gpadc_mfd_probe(struct platform_device *pdev)
+{
+	struct sunxi_gpadc_mfd_dev *sunxi_gpadc_mfd_dev = NULL;
+	struct resource *mem = NULL;

Neither of the above assignments is necessary as both will be explicitly
assigned before they are otherwise used.

ACK.

[...]

quoted

+	dev_info(&pdev->dev, "successfully loaded\n");

Seems like noise to me, but not my subsystem :)

ACK.
[...]