quoted hunk ↗ jump to hunk
+ chosen {
+ bootargs = "console=ttyS0,115200n8 earlyprintk";
+ linux,stdout-path = &uart0;
+ };
You can put the board rate etc in the stdout-patch. Something like:
stdout-path = "serial0:115200n8";
quoted hunk ↗ jump to hunk
+ gpio-leds {
+ compatible = "gpio-leds";
+ pinctrl-0 = <&pmx_power_led &pmx_power_led_blink &pmx_wan_led>;
+ pinctrl-names = "default";
+
+ led at 0 {
+ label = "power:green";
Documentation/leds/leds-class.txt says:
LED Device Naming
=================
Is currently of the form:
"devicename:colour:function"
quoted hunk ↗ jump to hunk
+ dsa at 0 {
+ compatible = "marvell,dsa";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dsa,ethernet = <ðport>;
+ dsa,mii-bus = <&mdio>;
+
+ switch at 0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0 0>; /* MDIO address 0, switch 0 in tree */
+
+ port at 0 {
+ reg = <0>;
+ label = "lan3";
+ };
+
+ port at 1 {
+ reg = <1>;
+ label = "lan4";
+ };
+
+ port at 2 {
+ reg = <2>;
+ label = "wan";
+ };
+
+ port at 3 {
+ reg = <3>;
+ label = "cpu";
+ };
+
+ port at 5 {
+ reg = <5>;
+ label = "lan1";
+ };
+
+ port at 7 {
+ reg = <7>;
+ label = "lan2";
+ };
+ };
+ };
+};
This all looks sensible, if a bit mixed up. Lets discuss the switch
issue in a different thread.
quoted hunk ↗ jump to hunk
+&devbus_bootcs {
+ status = "okay";
+
+ devbus,keep-config;
+
+ flash at 0 {
+ compatible = "cfi-flash";
+ reg = <0 0x800000>;
+ bank-width = <1>;
+ #address-cells = <1>;
+ #size-cells = <1>;
Documentation/devicetree/bindings/mtd/partition.txt says the
partitions should be placed under a partitions node. There are some
conditions when that does not work. So please try it, and if it does
not, ignore my comment...
quoted hunk ↗ jump to hunk
+
+ partition at 0 {
+ label = "kernel";
+ reg = <0x0 0x100000>;
+ };
+
+ partition at 100000 {
+ label = "rootfs";
+ reg = <0x100000 0x660000>;
+ };
+
+ partition at 760000 {
+ label = "uboot_env";
+ reg = <0x760000 0x20000>;
+ };
+
+ partition at 780000 {
+ label = "uboot";
+ reg = <0x780000 0x80000>;
+ read-only;
+ };
+ };
+};
quoted hunk ↗ jump to hunk
+&pinctrl {
+ pinctrl-0 = <&pmx_pci_gpios &pmx_ge>;
+ pinctrl-names = "default";
+
+ pmx_power_led: pmx-power-led {
+ marvell,pins = "mpp0";
+ marvell,function = "gpio";
+ };
+
+ pmx_reset_switch: pmx-reset-switch {
+ marvell,pins = "mpp1";
+ marvell,function = "gpio";
+ };
Ah, this is missing from your DSA node. You can then add:
reset-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>;
inside the switch at 0 node.
quoted hunk ↗ jump to hunk
+ pmx_ge: pmx-ge {
+ marvell,pins = "mpp9", "mpp12", "mpp13", "mpp14", "mpp15",
+ "mpp16", "mpp17", "mpp18", "mpp19";
+ marvell,function = "ge";
+ };
+};
This can go into the .dtsi file your previous patch added.
quoted hunk ↗ jump to hunk
+
+&uart0 {
+ /* Pin 1: Tx, Pin 7: Rx, Pin 8: Gnd */
+ status = "okay";
Nice to see the comment.
Andrew