[PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver

-----Original Message-----
From: Peter Chen [mailto:hzpeterchen at gmail.com]
Sent: Friday, July 15, 2016 12:43 PM
To: Rajesh Bhagat <redacted>
Cc: linux-usb at vger.kernel.org; linux-kernel at vger.kernel.org;
devicetree at vger.kernel.org; Peter Chen [off-list ref];
gregkh at linuxfoundation.org; kishon at ti.com; robh+dt at kernel.org;
shawnguo at kernel.org; linux-arm-kernel at lists.infradead.org
Subject: Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver

On Tue, Jul 12, 2016 at 03:59:07AM +0000, Rajesh Bhagat wrote:

quoted

quoted

quoted

+
+err_clks:
+	ci_hdrc_qoriq_disable_unprepare_clks(pdev);

If you have only one clock, it is unnecessary to use dedicated APIs for clock

operation.

quoted

quoted

We do have multiple clocks, but currently one is integrated in code.
Hence created the APIs for future use.

Hello Peter, 

If you could not integrate one more clocks, I suggest not creating dedicated API until
you need in future.

Okay, Will take care in v3. 

Best Regards,
Rajesh Bhagat 

--

Best Regards,
Peter Chen