On Thu, Jul 14, 2016 at 11:05:48AM -0700, Tai Tri Nguyen wrote:

Hi Joe,

On Thu, Jul 14, 2016 at 10:54 AM, Tai Tri Nguyen [off-list ref] wrote:

quoted

Hi Joe,

On Thu, Jul 14, 2016 at 10:47 AM, Joe Perches [off-list ref] wrote:

quoted

On Thu, 2016-07-14 at 10:27 -0700, Tai Nguyen wrote:

quoted

This patch adds a driver for the SoC-wide (AKA uncore) PMU hardware
found in APM X-Gene SoCs.

trivia:

quoted

diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c

[]

quoted

+struct xgene_pmu_dev_ctx {
+     char *name;
+     struct list_head next;
+     struct xgene_pmu_dev *pmu_dev;
+     struct hw_pmu_info inf;
+};

Probably better to use something like
        char    name[20];
as the kasprintf can fail and this doesn't
seem to be freed anywhere.

Okay. I'll fix it shortly.

I take it back.
I refer many other drivers using kasprintf and they do the same way I do.
Can you please check it again?

Joe is correct that you allocate a string with kasprintf, and this never
gets freed, even if the driver is removed. Thus, memory may be leaked.

If other drivers do the same, they are similarly wrong.

Even if this is a rare case, it's not good practice to leave allocations
unbalanced. So please fix this.

If you don't want to change the struct, another option is to use
devm_kasprintf. However, I suspect with all the accounting data
structures that will take up more space.

Thanks,
Mark.