Thread (6 messages) flat view 6 messages, 3 authors, 2016-08-09

[PATCH] usb: ehci-platform: use helper variables in probe function

From: stern@rowland.harvard.edu (Alan Stern)
Date: 2016-07-14 14:11:34
Also in: lkml

On Wed, 13 Jul 2016, Rafa? Mi?ecki wrote:
Probing function was using &dev->dev and dev->dev.of_node over 20 times
so I believe it made sense to use helper variables for both of them.
To avoid some uncommon variable name for struct device I first replaced
existing dev variable with pdev.

Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
Okay except for...
-		priv->num_phys = of_count_phandle_with_args(dev->dev.of_node,
-				"phys", "#phy-cells");
+		priv->num_phys = of_count_phandle_with_args(np, "phys",
+							    "#phy-cells");
Please indent continuation lines two tab stops beyond the original 
line, to match the style in the rest of the source file.

With that change,

Acked-by: Alan Stern <stern@rowland.harvard.edu>

Alan Stern
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help