Thread (1 message) 1 message, 1 author, 2016-07-11

[PATCH v2 1/6] dt-bindings: clock: add DT binding for the Xtal clock on Armada 3700

From: Gregory CLEMENT <hidden>
Date: 2016-07-11 16:12:31
Also in: linux-clk, linux-devicetree, lkml

Hi Thomas,
 
 On ven., juil. 08 2016, Thomas Petazzoni [off-list ref] wrote:
Hello,

On Fri,  8 Jul 2016 00:37:46 +0200, Gregory CLEMENT wrote:
quoted
+gpio1: gpio at 13800 {
+	compatible = "marvell,mvebu-gpio-3700",	"syscon", "simple-mfd";
I find this compatible string not very consistent with what we do for
other drivers, it should have been:

	marvell,armada-3700-gpio
Thanks for pointing this. We missed it during the last review. I agree
that using marvell,armada-3700-gpio is more appropriate, especially
because the gpio controller on Armada 37xx seems to be different that
the ones used on the other mvebu SoCs.

Gregory
or something like that.

quoted
+	xtalclk: xtal-clk {
+		compatible = "marvell,armada-3700-xtal-clock";
See here for example.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help