Thread (22 messages) 22 messages, 4 authors, 2016-07-11

[PATCH v3 13/14] clk: sunxi-ng: Add H3 clocks

From: mturquette@baylibre.com (Michael Turquette)
Date: 2016-07-07 02:33:15
Also in: linux-clk, linux-devicetree, lkml

Hi Maxime,

Quoting Maxime Ripard (2016-06-29 12:05:34)
+static void __init sun8i_h3_ccu_setup(struct device_node *node)
+{
+       void __iomem *reg;
+       u32 val;
+
+       reg = of_io_request_and_map(node, 0, of_node_full_name(node));
+       if (IS_ERR(reg)) {
+               pr_err("%s: Could not map the clock registers\n",
+                      of_node_full_name(node));
+               return;
+       }
+
+       /* Force the PLL-Audio-1x divider to 4 */
+       val = readl(reg + SUN8I_H3_PLL_AUDIO_REG);
+       val &= ~GENMASK(4, 0);
+       writel(val | 3, reg + SUN8I_H3_PLL_AUDIO_REG);
+
+       sunxi_ccu_probe(node, reg, &sun8i_h3_ccu_desc);
+}
+CLK_OF_DECLARE(sun8i_h3_ccu, "allwinner,sun8i-h3-ccu",
+              sun8i_h3_ccu_setup);
There are several examples of drivers that split the clocks between
"early" CLK_OF_DECLARE clocks and "late" module clocks. If you really
need early clocks (which is less likely on a 64-bit platform with
architected timers), it would be nice to pair that with a proper
platform_driver (using builtin_platform_driver most likely).

Otherwise that is my only nitpick with this series. Looks good!

Best regards,
Mike
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help