[PATCH v2] clkdev: add devm_of_clk_get()

From
Michael Turquette <hidden>
Date
2016-07-07 00:49:41
Also in
alsa-devel, linux-clk, linux-devicetree, lkml
Reply to
Kuninori Morimoto, 2016-07-04
Quoting Kuninori Morimoto (2016-07-03 18:36:50)
+struct clk *devm_of_clk_get(struct device *dev,
+                           struct device_node *np, int index)
Any reason not to use devm_clk_get? Why do we need this helper?

Thanks,
Mike
quoted hunk ↗ jump to hunk
+{
+       struct clk **ptr, *clk;
+
+       ptr = devres_alloc(devm_of_clk_release, sizeof(*ptr), GFP_KERNEL);
+       if (!ptr)
+               return ERR_PTR(-ENOMEM);
+
+       clk = of_clk_get(np, index);
+       if (!IS_ERR(clk)) {
+               *ptr = clk;
+               devres_add(dev, ptr);
+       } else {
+               devres_free(ptr);
+       }
+
+       return clk;
+}
+EXPORT_SYMBOL(devm_of_clk_get);
+
 static struct clk *__of_clk_get_by_name(struct device_node *np,
                                        const char *dev_id,
                                        const char *name)
diff --git a/include/linux/clk.h b/include/linux/clk.h
index a89ba4e..33cd540 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -502,6 +502,8 @@ struct of_phandle_args;
 
 #if defined(CONFIG_OF) && defined(CONFIG_COMMON_CLK)
 struct clk *of_clk_get(struct device_node *np, int index);
+struct clk *devm_of_clk_get(struct device *dev,
+                           struct device_node *np, int index);
 struct clk *of_clk_get_by_name(struct device_node *np, const char *name);
 struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec);
 #else
@@ -509,6 +511,11 @@ static inline struct clk *of_clk_get(struct device_node *np, int index)
 {
        return ERR_PTR(-ENOENT);
 }
+static inline struct clk *devm_of_clk_get(struct device *dev,
+                           struct device_node *np, int index)
+{
+       return ERR_PTR(-ENOENT);
+}
 static inline struct clk *of_clk_get_by_name(struct device_node *np,
                                             const char *name)
 {
-- 
1.9.1
Thread (16 messages) 16 messages, 4 authors, last reply 2016-12-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help