RE: [PATCH 7/7] devfreq: exynos-bus: add missing of_node_put after calling of_parse_phandle
From: myungjoo.ham@samsung.com (MyungJoo Ham)
Date: 2016-07-06 02:47:57
Also in:
linux-pm, linux-renesas-soc, linux-samsung-soc, lkml
--------- Original Message --------- Sender : Peter Chen [off-list ref] Date : 2016-07-01 18:49 (GMT+9) Title : [PATCH 7/7] devfreq: exynos-bus: add missing of_node_put after calling of_parse_phandle of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Cc: Chanwoo Choi <cw00.choi@samsung.com> Cc: MyungJoo Ham <myungjoo.ham@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Kukjin Kim <kgene@kernel.org> Cc: Krzysztof Kozlowski <redacted> Signed-off-by: Peter Chen <redacted>
With the change (build error fix) of the following added, (I'll update) Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com> Cheers, MyungJoo
quoted hunk
--- drivers/devfreq/exynos-bus.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 2363d0a..a38b5ec 100644 --- a/drivers/devfreq/exynos-bus.c +++ b/drivers/devfreq/exynos-bus.c@@ -383,7 +383,7 @@ err_clk: static int exynos_bus_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct device_node *np = dev->of_node; + struct device_node *np = dev->of_node, node;
+ struct device_node *np = dev->of_node, *node;
struct devfreq_dev_profile *profile;
struct devfreq_simple_ondemand_data *ondemand_data;
struct devfreq_passive_data *passive_data;...